Hbbaker #1749
Open
Hbbaker #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to a utility class so as to improve clutter and readability of the CenterLines public functions, as well as improving the maintainability of the class moving forward. Also updated tests to reflect changes in imports to ensure that code stays in working order.
…ode, as well as fixed a bad reference left over from refactoring in centerlines_utils
…nes_utils that accidentally duplicated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I have been watching this project for a little while now and I love what it aims to do and how useful it is. I am pretty new to OpenSource and I wanted to contribute to the project. While looking through some of the core components I noticed that there is a lot of clutter with private functions, as well as a bit of scope creep in that functionality. I noticed this particularly in CenterLines class / functions. I didn't want to change any functionality, but I thought it might be interesting to try to clean up some of the functions so that the top level capabilities of CenterLines are isolated from the helpers that can be isolated to improve future maintainability! I'd love any feedback you have to offer as well!