Add support for InterSystems IRIS as an additional database platform #377
+229
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR introduces support for the InterSystems IRIS Data Platform to SqlRender. It includes all the required replacement rules to make sure OHDSI tool-generated statements run fine on InterSystems IRIS. In addition, appropriate unit tests and changes to the ref/doc pages are included in this PR.
This PR for SqlRender is the first step of adding InterSystems IRIS support to a broader set of OHDSI tools, as the dialect needs to become part of a SqlRender release in order to be able to submit corresponding PRs for the DatabaseConnector, CommonDataModel, ArachneCommons, WebAPI and Atlas repositories that we have lined up and ready to submit. As such, it would be great if this could make it into the upcoming 1.18.1 release, and we are ready to make any further changes to the PR as required to facilitate approval.
Context: Dr. Qi Li has recently reached out to @schuemie to discuss our work at InterSystems and the OHDSI toolset support effort, which we've done with support of the Oddyseus Data Services team and @alex-odysseus in particular.