tests: showcase verdict field/events in tests - v2 #1293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suricata PR: OISF/suricata#9162 |
|
Hmmm.... I guess |
With the addition of the 'verdict' field, have at least one test that illustrates this, and adjust tests that were affected by that change. Bug #5464
jufajardini
force-pushed
the
alert-action-sv/v4
branch
from
2fa0c43
to
8c7ced8
Compare
|
Replaced by: #1308 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of the 'verdict' field, have at least one test that illustrates this, and adjust tests that were affected by that change.
Bug #5464
Previous PR: #1145
Changes from previous PR:
stream-depth-reached-eventfor the command-line argument to workTODOs:
add more tests, to showcase examples seen in: OISF/suricata#8596 (comment)
Ticket
Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5464