mime: add tests for bug 6207 #1313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catenacyber
reviewed
Jul 13, 2023
| =Mg | ||
| == | ||
| ``` | ||
| should ideally get decoded to `42` as demonstrated in this test. |
There was a problem hiding this comment.
as NA==Mg== gets decoded into 42 as well (whatever the line feeds)
catenacyber
reviewed
Jul 13, 2023
| default < (content:"250 2.1.5 Ok\x0d\x0a";); | ||
| default > (content:"DATA\x0d\x0a";); | ||
| default < (content:"354 End data with <CR><LF>.<CR><LF>\x0d\x0a";); | ||
| default > (content:"Subject: SMTPbelka-test_sans_name2021-03-08-17:28:53-221a0d8d17b3b41e28ec113dcabb55da7bdb03a8c0bb5d3de252f5d69347aa4d.zip\x0d\x0a";); |
There was a problem hiding this comment.
We could change the dummy subject
catenacyber
reviewed
Jul 13, 2023
| default > (content:"\x0d\x0a";); | ||
| default > (content:"\x0d\x0a";); | ||
| default > (content:"--KkK170891tpbkKk__FV_KKKkkkjjwq\x0d\x0a";); | ||
| default > (content:"Content-Type: application/zip;\x0d\x0a";); |
There was a problem hiding this comment.
This is no longer a zip ;-)
catenacyber
reviewed
Jul 13, 2023
| @@ -0,0 +1 @@ | |||
| alert tcp any any -> any any (msg: "Test file content"; file.data; content:"42"; sid:1;) | |||
There was a problem hiding this comment.
Can we add filesize: 2 keyword to ensure the file is exactly 42 ant not having 42 as a substring ?
Merged
|
Merged in #1315, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6207
Previous PR: #1312
Changes since v4:
file.datarule to match on file content for testbug-6207-2