sip: add tests for sip over tcp #1341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suricata PR: OISF/suricata#9321 |
3 tasks
This was referenced Aug 15, 2023
catenacyber
reviewed
Aug 30, 2023
| requires: | ||
| features: | ||
| - HAVE_LIBJANSSON | ||
| min-version: 5.0.0 |
There was a problem hiding this comment.
Should be 7 (and for other tests)
catenacyber
reviewed
Aug 30, 2023
| @@ -0,0 +1,2 @@ | |||
| alert sip any any -> any any (flow:to_server; sip.protocol; content:"SIP/2.0"; sid:1;) | |||
| alert sip any any -> any any (flow:to_client; sip.protocol; content:"SIP/2.0"; sid:2;) | |||
There was a problem hiding this comment.
I wonder if it makes more sense to have only one test sip-tcp-keywords...
catenacyber
reviewed
Aug 30, 2023
| @@ -0,0 +1,26 @@ | |||
| requires: | |||
| features: | |||
| - HAVE_LIBJANSSON | |||
There was a problem hiding this comment.
You do not need to put this with min-version 7 ;-)
|
Replaced by #1386 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for sip over tcp.
Update:
Redmine ticket
https://redmine.openinfosecfoundation.org/issues/3351