Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/transform: from_base64 test #1670

Closed
wants to merge 1 commit into from
Closed

tests/transform: from_base64 test #1670

wants to merge 1 commit into from

Conversation

jlucovsky
Copy link
Contributor

@jlucovsky jlucovsky commented Feb 27, 2024 •
edited
Loading

from_base64 transform test

Ticket

If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:

Redmine ticket: 6487

Updates

  • Mode specific tests

@jlucovsky
Copy link
Contributor Author

jlucovsky commented Feb 27, 2024 •
edited
Loading

Continued in #10512

Oops -- erroneously closed.

@jlucovsky jlucovsky closed this Feb 27, 2024
@jlucovsky jlucovsky reopened this Feb 27, 2024
@victorjulien
Copy link
Member

Can you also add a test that depends on the mode? Ideally we'd have one per option, that would only pass with that specific "mode" setting.

@catenacyber catenacyber added the requires suricata pr Depends on a PR in Suricata label Feb 29, 2024
This was referenced Apr 24, 2024
Closed
Closed
Closed
@victorjulien
Copy link
Member

Additional request: add some tests that force the pattern after from_base64 to be the fast pattern.

@jlucovsky jlucovsky mentioned this pull request Apr 30, 2024
Closed
@jlucovsky
Copy link
Contributor Author

Additional request: add some tests that force the pattern after from_base64 to be the fast pattern.

Will do.

@jlucovsky
Copy link
Contributor Author

Can you also add a test that depends on the mode? Ideally we'd have one per option, that would only pass with that specific "mode" setting.

Yes; done.

@jlucovsky jlucovsky mentioned this pull request May 1, 2024
Closed
@jlucovsky
tests/transform: from_base64 test
5c5f946 
Issue: 6487

Test cases for the from_base64 transform
- Case 01 tests RFC4648 (default) with various offsets
- Case 02 tests RFC2045 and verifies success and failure case
  (with other modes)
- Case 03 -- case 01 with fast_pattern associated with the
  post transform content.
This was referenced Jun 13, 2024
Closed
Closed
This was referenced Jun 21, 2024
Closed
Closed
@victorjulien victorjulien mentioned this pull request Jun 22, 2024
Merged
@victorjulien
Copy link
Member

Merged in #1937, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catenacyber catenacyber catenacyber left review comments

@victorjulien victorjulien victorjulien approved these changes

Assignees
No one assigned
Labels
requires suricata pr Depends on a PR in Suricata
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlucovsky @victorjulien @catenacyber