Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: remove tests for versions less than 6 #1934

Closed
wants to merge 1 commit into from
Closed

tests: remove tests for versions less than 6 #1934

wants to merge 1 commit into from

Conversation

jasonish
Copy link
Member

No description provided.

@jasonish jasonish mentioned this pull request Jun 21, 2024
Closed
@victorjulien victorjulien added the tests pass These new tests should pass label Jun 22, 2024
catenacyber
catenacyber approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I do not see anymore 5 or 4 versions unless it is min-version

@victorjulien victorjulien mentioned this pull request Jul 4, 2024
Merged
@victorjulien
Copy link
Member

Merged in #1962, thanks!

@jasonish jasonish deleted the remove-old-tests/v1 branch August 15, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien victorjulien approved these changes

@catenacyber catenacyber catenacyber approved these changes

Assignees
No one assigned
Labels
tests pass These new tests should pass
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonish @victorjulien @catenacyber