output/dns: do not add empty app-layer metadata

OISF · Nov 23, 2023 · 569d615 · 569d615
1 parent c1dfa6e
commit 569d615
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/output-json-dns.c b/src/output-json-dns.c
@@ -306,19 +306,22 @@ static JsonBuilder *JsonDNSLogAnswer(void *txptr)
 
 bool AlertJsonDns(void *txptr, JsonBuilder *js)
 {
+    bool r = false;
     jb_open_object(js, "dns");
     JsonBuilder *qjs = JsonDNSLogQuery(txptr);
     if (qjs != NULL) {
         jb_set_object(js, "query", qjs);
         jb_free(qjs);
+        r = true;
     }
     JsonBuilder *ajs = JsonDNSLogAnswer(txptr);
     if (ajs != NULL) {
         jb_set_object(js, "answer", ajs);
         jb_free(ajs);
+        r = true;
     }
     jb_close(js);
-    return true;
+    return r;
 }
 
 static int JsonDnsLoggerToServer(ThreadVars *tv, void *thread_data,