Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-layer: websockets protocol support #10060

Closed
wants to merge 1 commit into from
Closed

app-layer: websockets protocol support #10060

wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Contributor

@catenacyber catenacyber commented Dec 14, 2023 •
edited
Loading

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2695

Describe changes:

  • app-layer: websockets protocol support
  • rust : derive for protocol enumerations strings
SV_BRANCH=pr/1550

OISF/suricata-verify#1550

#10014 with all TODOs done

  • no use of expectation
  • payload keyword
  • mask keyword and logging as u32
  • fin boolean logging and keyword

@catenacyber catenacyber mentioned this pull request Dec 14, 2023
Closed
@catenacyber
app-layer: websockets protocol support
77d1c77 
Ticket: 2695

Introduces a device EnumStringU8 to ease the use of enumerations
in protocols : logging the string out of the u8,
and for detection, parsing the u8 out of the string
@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPW1_files_sha256.

field baseline test %
SURI_TLPW1_stats_chk
.app_layer.flow.dns_tcp 2637 335 12.7%
.app_layer.flow.failed_tcp 10177 2388 23.46%
.app_layer.tx.dns_tcp 5269 664 12.6%
.app_layer.error.tls.parser 1145 944 82.45%
SURI_TLPR1_stats_chk
.app_layer.flow.smb 41552 28369 68.27%
.app_layer.flow.failed_tcp 181108 149435 82.51%
.app_layer.tx.smb 218583 140903 64.46%
.app_layer.error.ftp.parser 364 342 93.96%
.app_layer.error.dcerpc_tcp.parser 6248 9 0.14%
.app_layer.error.dns_tcp.parser 30 8 26.67%
.app_layer.error.rfb.parser 1 0 -
IPS_AFP_stats_chk
.app_layer.flow.smb 243000 135000 55.56%
.app_layer.flow.failed_tcp 109080 55075 50.49%
.app_layer.tx.smb 2267998 1836000 80.95%
.memcap_pressure_max 35 37 105.71%
TREX_GENERIC_stats_chk
.app_layer.flow.smb 141752 54824 38.68%
.app_layer.flow.failed_tcp 110076 45350 41.2%
.app_layer.tx.smb 1165708 731596 62.76%

Pipeline 17097

@catenacyber catenacyber mentioned this pull request Dec 19, 2023
Closed
@catenacyber
Copy link
Contributor Author

Rebased in #10074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

@victorjulien victorjulien Awaiting requested review from victorjulien victorjulien is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catenacyber @suricata-qa