Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect dynamic register keywords 4683 v3 #11035

Closed
wants to merge 7 commits into from
Closed

Detect dynamic register keywords 4683 v3 #11035

wants to merge 7 commits into from

Commits on May 7, 2024

  1. tests: do not bother to free a null pointer

    @catenacyber
    catenacyber committed May 7, 2024
    Configuration menu
    Copy the full SHA
    fbfee2b View commit details
    Browse the repository at this point in the history

  2. rust: return empty slice without using from_raw_parts 

    As this triggers rustc 1.78
unsafe precondition(s) violated: slice::from_raw_parts requires
the pointer to be aligned and non-null,
and the total size of the slice not to exceed `isize::MAX`
    @catenacyber
    catenacyber committed May 7, 2024
    Configuration menu
    Copy the full SHA
    ce982b1 View commit details
    Browse the repository at this point in the history

  3. app-layer: do not probe a gap 

    If the flow begins with a gap, do not try run probing parsers
to recognize app-layer on it, as they have no data.
    @catenacyber
    catenacyber committed May 7, 2024
    Configuration menu
    Copy the full SHA
    bb70725 View commit details
    Browse the repository at this point in the history

  4. fuzz: build with dependencies on rust and c lib 

    So that there is no need to remove the final binary, to recompile
it if there has been changes in the code.
    @catenacyber
    catenacyber committed May 7, 2024
    Configuration menu
    Copy the full SHA
    964a384 View commit details
    Browse the repository at this point in the history

  5. detect: helper to have pure rust keywords 

    detect: make number of keywords dynamic

Ticket: 4683
    @catenacyber
    catenacyber committed May 7, 2024
    Configuration menu
    Copy the full SHA
    5715170 View commit details
    Browse the repository at this point in the history

  6. detect/snmp: move keywords to rust 

    Ticket: 4863

On the way, convert unit test DetectSNMPCommunityTest to a SV test.

And also, make snmp.pdu_type use a generic uint32 for detection,
allowing operators, instead of just equality.
    @catenacyber
    catenacyber committed May 7, 2024
    Configuration menu
    Copy the full SHA
    41da302 View commit details
    Browse the repository at this point in the history

  7. fixup dpdk

    @catenacyber
    catenacyber committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0f9a9ba View commit details
    Browse the repository at this point in the history