bypass: really bypass udp flow from first packet #11182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7053 As flow state would be overwritten by established...
|
SV test would show |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11182 +/- ##
===========================================
- Coverage 82.93% 74.84% -8.09%
===========================================
Files 942 875 -67
Lines 250797 144738 -106059
===========================================
- Hits 207994 108331 -99663
+ Misses 42803 36407 -6396
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 20876 |
| (f->flow_state != FLOW_STATE_CAPTURE_BYPASSED) && | ||
| #endif | ||
| (f->flow_state != FLOW_STATE_LOCAL_BYPASSED)) { | ||
| FlowUpdateState(f, FLOW_STATE_ESTABLISHED); |
There was a problem hiding this comment.
should we flag the packet as part of an established flow in this case, as we do on line 486?
There was a problem hiding this comment.
I guess so.
We have
- UDP from client to server, nothing special
- UDP from server to client, we trigger a
bypassrule thatFlowUpdateState(FLOW_STATE_LOCAL_BYPASSED), and in later processing, we callFlowHandlePacketUpdatethat also sees the flow as established...
|
Rebased in #11287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7053
Describe changes:
SV_BRANCH=OISF/suricata-verify#1870