-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next/466/20240604/v1 #11236
next/466/20240604/v1 #11236
Conversation
'dir' was too generic, so indicate it's about the app-layer update direction.
'dir' was too generic, so indicate it's about the app-layer update direction.
Getter for the most recent frame with unknown length (-1).
AppLayerFrameGetLastOpenByType: Returns the most recent frame with a type with unknown length (-1). Check if type is globally enabled first.
Make sure to only scan the data when the app layer has been updated as well. Ticket: OISF#6718.
Add new flags to trigger FLOW_TS_APP_UPDATED/FLOW_TC_APP_UPDATED flags to be set for the next packet in the relevant direction. This allows for app relevant work to be done in the next packet in our direction.
Inspect frames in the correct direction after they have been created.
There will generally not be an opposing direction to handle the app update.
Adds the following frames: command_line data response_line The *_line frames are per line, so in multi-line responses each line will have it's own frame. Ticket: OISF#4905.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11236 +/- ##
==========================================
+ Coverage 82.96% 82.99% +0.02%
==========================================
Files 942 942
Lines 249246 249358 +112
==========================================
+ Hits 206789 206951 +162
+ Misses 42457 42407 -50
Flags with carried forward coverage won't be shown. Click here to find out more. |
Information: QA ran without warnings. Pipeline 20951 |
line. Lines part of the SMTP DATA transfer are excluded. | ||
|
||
.. container:: example fule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the name of the CSS container. These rules may not render as intended. It should be example-rule
.
Staging:
SV_BRANCH=OISF/suricata-verify#1887