Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataset string memcap 3910/v13 #11289

Closed
wants to merge 5 commits into from
Closed

Dataset string memcap 3910/v13 #11289

wants to merge 5 commits into from

Commits on Jun 10, 2024

  1. thash: add expiration logic 

    Add a callback and helper function to handle data expiration.

Update datasets to explicitly not use expiration.
    @victorjulien @inashivb
    victorjulien authored and inashivb committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    261d2bb View commit details
    Browse the repository at this point in the history

  2. util/thash: add a length getter fn 

    In order to have access to the length of datatypes with variable lengths
to correctly update memuse to calculate memcaps.

Bug 3910
    @inashivb
    inashivb committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    d0116ae View commit details
    Browse the repository at this point in the history

  3. datasets: fix memuse to include string len 

    So far, when the data size was passed to the THash API, it was sent as
a sizeof(Struct) which works fine for the other data types as they have
a fixed length but not for the StringType.
However, because of the sizeof construct, the length of a string type
dataset was always taken to be 16 Bytes which is only the size of the struct
itself. It did not accomodate the actual size of the string that the
StringType holds. Fix this so that the memuse that is used to determine
whether memcap was reached also takes into consideration the size of the
actual string.

Bug 3910
    @inashivb
    inashivb committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    444da6d View commit details
    Browse the repository at this point in the history

  4. doc: add note about datasets string memcaps 

    Bug 3910
    @inashivb
    inashivb committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    52778f9 View commit details
    Browse the repository at this point in the history

  5. applayer/htp-range: fix off by one in expiry check

    @inashivb
    inashivb committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    b08b661 View commit details
    Browse the repository at this point in the history