Warning integers 64to32 6186 v20.2 #11416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorjulien
reviewed
Jul 4, 2024
| @@ -422,7 +422,7 @@ static uint32_t FlowTimeoutHash(FlowManagerTimeoutThread *td, SCTime_t ts, const | |||
| #define TYPE uint32_t | |||
| #endif | |||
|
|
|||
| const uint32_t ts_secs = SCTIME_SECS(ts); | |||
| const time_t ts_secs = SCTIME_SECS(ts); | |||
There was a problem hiding this comment.
the second tracking in the flow engine is currently all u32, so I would suggest leaving this as u32 until we want to move it to a larger type
|
Continued in #11422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186
Describe changes:
-Wshorten-64-to-32warnings for some files (c*, f*)Some commits of #9840
#11257 next batch
#11367 with only commits for integers