-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detect: make events prefilterable #11577
detect: make events prefilterable #11577
Conversation
and use SIG_MASK_REQUIRE_ENGINE_EVENT
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11577 +/- ##
=======================================
Coverage 82.50% 82.51%
=======================================
Files 923 923
Lines 248721 248753 +32
=======================================
+ Hits 205215 205256 +41
+ Misses 43506 43497 -9
Flags with carried forward coverage won't be shown. Click here to find out more. |
My debug print is not agreeing with codecov : I see |
Oh, codecov shows "?" for suricata-verify coverage... |
We can still retrieve the data codecov sees as buggy and see
So, there is more coverage than said here... |
Information: QA ran without warnings. Pipeline 21758 |
TODO: SV test should test prefilter auto mode |
Rebased in #11604 |
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/6728
Describe changes:
Follows on #11559 rebased to get green CI, and hopefully not buggy codecov report
SV_BRANCH=OISF/suricata-verify#1992