Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnint 64to32 6186 v22.1 #11580

Closed

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186

Describe changes:

  • fix -Wshorten-64-to-32 warnings for some files : log, source

Some commits of #9840
#11524 next batch

Still to do afterwards :

  • detect
  • output
  • stream
  • util

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.49%. Comparing base (da1645b) to head (900cb07).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11580      +/-   ##
==========================================
- Coverage   82.50%   82.49%   -0.01%     
==========================================
  Files         923      923              
  Lines      248721   248721              
==========================================
- Hits       205215   205191      -24     
- Misses      43506    43530      +24     
Flag Coverage Δ
fuzzcorpus 60.51% <11.11%> (ø)
livemode 18.63% <11.11%> (-0.01%) ⬇️
pcap 43.66% <0.00%> (-0.41%) ⬇️
suricata-verify 61.75% <20.00%> (-0.03%) ⬇️
unittests 59.06% <11.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 21762

@victorjulien victorjulien added this to the 8.0 milestone Jul 30, 2024
This was referenced Jul 31, 2024
@victorjulien
Copy link
Member

Merged in #11595, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants