rust/ldap: udp and frames support v4 #11582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a new parser registration function for LDAP/UDP, and update ldap configuration in order to be able to enable/disable a single parser independently (such as dns). Also, GAPs are accepted only for TCP parser and not for UDP.
This adds a pdu frame for both request and response, and removes invalid returns in SCLdapParseRequest and SCLdapParseResponse.
Following the same logic as for PGSQL, if there is a gap in an LDAP request or response, the parser tries to sync up again by checking if the message can be parsed and effectively parses it on the next call.
4 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11582 +/- ##
==========================================
- Coverage 82.50% 82.42% -0.08%
==========================================
Files 923 923
Lines 248721 248846 +125
==========================================
- Hits 205215 205120 -95
- Misses 43506 43726 +220
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Jul 30, 2024
Closed
|
Still failing Did you check what is checked there and why this PR might hit the check? |
|
Replaced with #11597 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are signed before submitting your Pull Request -- thank you.
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
(if applicable)
Link to ticket: https://redmine.openinfosecfoundation.org/issues/1199
Describe changes:
SV_BRANCH=OISF/suricata-verify#1984