Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: more robust download of netmap #11903

Closed
wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
None, just make CI more robust

Describe changes:

  • git clone netmap instead of using actions/checkout

@jasonish
Copy link
Member

jasonish commented Oct 8, 2024

How will we know if it helps? But, its easier to cache this way.

@catenacyber
Copy link
Contributor Author

How will we know if it helps? But, its easier to cache this way.

If this CI fails, we know it does not help...

But please, tell me you have some better solution as this is indeed not elegant :-)

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (6ae5ae7) to head (0ab2afb).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11903      +/-   ##
==========================================
+ Coverage   82.60%   82.62%   +0.01%     
==========================================
  Files         912      912              
  Lines      249342   249342              
==========================================
+ Hits       205968   206014      +46     
+ Misses      43374    43328      -46     
Flag Coverage Δ
fuzzcorpus 60.68% <ø> (+0.04%) ⬆️
livemode 18.72% <ø> (+<0.01%) ⬆️
pcap 44.07% <ø> (-0.01%) ⬇️
suricata-verify 62.02% <ø> (-0.01%) ⬇️
unittests 58.94% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@catenacyber
Copy link
Contributor Author

Replaced by #11918

@catenacyber catenacyber closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants