updating unittests in src/app-layer-htp.c to new FAIL/PASS API/v1 #11909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: This PR may contain new authors. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11909 +/- ##
==========================================
- Coverage 82.56% 79.12% -3.44%
==========================================
Files 912 912
Lines 249354 249151 -203
==========================================
- Hits 205880 197152 -8728
- Misses 43474 51999 +8525
Flags with carried forward coverage won't be shown. Click here to find out more. |
inashivb
requested changes
Oct 9, 2024
There was a problem hiding this comment.
Congrats on your first contribution, @Nancyenos ! :)
The changes are looking ok from a brief overview, however, we need to rework a few things:
- Rebase your branch on the latest master
- Cover all the tests in this file
- Commit message should be reworded to something like:
applayer/htp: convert to new FAIL/PASS API
Nice first try! ⭐
|
Thank you @inashivb .Working on it! |
|
Please open a new branch and PR for implementing the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #6935
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Describe changes:
-updated HTPParserTest01a in src/app-layer-htp.c to new FAIL/PASS API
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=