Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applayer plugin 5053 v3.5 #11910

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053

Describe changes:

  • get ready to use dynamic number of app-layer protos (also work with static constant) in some places
  • preventive fix of macro with parenthesis cc @jufajardini

#11572 next round

#11795 with comments taken into account

Still more work to do after :
Only AppProtoStrings is to be handled, but it is the big one.

And then take remaining commits out of #11321
And supply an example of an app-layer plugin

instead of a global variable.

For easier initialization with dynamic number of protocols
for expectation_proto

Ticket: 5053
so that we can use safely EXCEPTION_POLICY_MAX*sizeof(x)
Ticket: 5053

delay after initialization so that StringToAppProto works
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 90.52632% with 18 lines in your changes missing coverage. Please review.

Project coverage is 82.42%. Comparing base (6ae5ae7) to head (b03265b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11910      +/-   ##
==========================================
- Coverage   82.60%   82.42%   -0.19%     
==========================================
  Files         912      912              
  Lines      249342   249350       +8     
==========================================
- Hits       205968   205519     -449     
- Misses      43374    43831     +457     
Flag Coverage Δ
fuzzcorpus 59.84% <80.85%> (-0.79%) ⬇️
livemode 18.87% <69.14%> (+0.15%) ⬆️
pcap 44.08% <84.04%> (+<0.01%) ⬆️
suricata-verify 61.99% <90.42%> (-0.04%) ⬇️
unittests 58.93% <69.47%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23058

@catenacyber
Copy link
Contributor Author

There are still discussions:

  • Should we use void *(*alproto_local_storage)[FLOW_PROTO_MAX]; alproto_local_storage[alproto][flow_proto] or void **alproto_local_storage; alproto_local_storage[alproto*FLOW_PROTO_MAX+flow_proto] Applayer plugin 5053 v3.4 #11795 (comment)
  • Could we remove ALPROTO_TEST as the tests do not make sense to me ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants