[draft] threads: move wait for unpause outside of loop - v2 #11936
+38
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pattern of checking the pause flag, setting to paused then waiting to unpause was done enough times to factor out into its own function. This is also needed by library users who bring their own packet acquisition threads.
TmThreadTestThreadUnPaused was only being used by TmThreadsWaitForUnpause and is still enough to just become one function.
Threads are only set to paused upon initialization and never again, we should only have to wait once, so move the wait before any loop that was waiting before.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11936 +/- ##
==========================================
- Coverage 82.74% 82.73% -0.01%
==========================================
Files 912 912
Lines 249102 249081 -21
==========================================
- Hits 206117 206081 -36
- Misses 42985 43000 +15
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -406,13 +406,8 @@ static void *StatsMgmtThread(void *arg) | |||
| SCLogDebug("stats_thread_data %p", &stats_thread_data); | |||
|
|
|||
| TmThreadsSetFlag(tv_local, THV_INIT_DONE | THV_RUNNING); | |||
| TmThreadsWaitForUnpause(tv_local); | |||
There was a problem hiding this comment.
should we avoid entering the while loop if this returned early due to the kill flag being set?
|
Information: QA ran without warnings. Pipeline 23086 |
|
Replaced by #11943. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, just pushing for QA purposes.
Per #11923 (comment)