De cleanups/20241010/v2 #11937
Open
De cleanups/20241010/v2 #11937
+58
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done following the fact that this setting was historically named incorrectly. The purpose of the setting was always to define the ports that will be prioritized and have rule groups associated w them on priority. Rename all occurences of this to correctly reflect the purpose of the setting.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11937 +/- ##
==========================================
- Coverage 82.74% 82.73% -0.02%
==========================================
Files 912 912
Lines 249102 249088 -14
==========================================
- Hits 206117 206078 -39
- Misses 42985 43010 +25
Flags with carried forward coverage won't be shown. Click here to find out more. |
inashivb
force-pushed
the
de-cleanups/20241010/v2
branch
from
3f6dd37
to
6931e8f
Compare
|
Information: QA ran without warnings. Pipeline 23087 |
|
|
||
| const char *ports = NULL; | ||
| (void)ConfGet("detect.grouping.tcp-whitelist", &ports); |
There was a problem hiding this comment.
we need to handle old configs as well, which means we first read the new tcp-priorityports option, but if it doesn't exist, we try tcp-whitelist
Btw tcp-priority-ports looks better to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #11928
Changes since v1: