af-packet: Remove support for rollover #9123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the summary message when Suricata terminates. Without this commit, "nan" was displayed if there were no drops/packets
Issue: 6128 cluster_rollover is no longer permitted; using it will generate a warning message and it'll be replaced with cluster_flow
Issue: 6128 No longer permit rollover/cluster_rollover to be used. Usage will generate a warning message and cluster_flow will be used instead.
jlucovsky
requested review from
jufajardini,
victorjulien and
a team
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9123 +/- ##
==========================================
- Coverage 82.31% 82.30% -0.01%
==========================================
Files 969 969
Lines 273741 273740 -1
==========================================
- Hits 225329 225314 -15
- Misses 48412 48426 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 14954 |
victorjulien
requested changes
Jul 4, 2023
victorjulien
reviewed
Jul 4, 2023
victorjulien
reviewed
Jul 4, 2023
|
Continued in #9148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #9069
This MR removes support for AF-Packet rollover.
Rollover support is defined here.
If
cluster-type: cluster_rolloveris configured, a warning message will be displayed and the clustering used will becluster_flow.The warning message:
Link to redmine ticket: 6128
Describe changes:
cluster-type: cluster_rollover) and usecluster_flowinsteadUpdates
rolloverhandling per review feedback.Provide values to any of the below to override the defaults.
To use a pull request use a branch name like
pr/NwhereNis the pull request number.