Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next/61/20230703/v1 #9135

Closed
wants to merge 3 commits into from
Closed

Conversation

victorjulien
Copy link
Member

satta and others added 3 commits July 3, 2023 10:14
If an exception policy wasn't set up individually, use the GetDefault
function to pick one. This will check for the master switch option and
handle 'auto' cases.

Instead of deciding what the auto value should be when we are parsing
the master switch, leave that for when some of the other policies is to
be set via the master switch, when since this can change for specific
exception policies - like for midstream, for instance.

Update exceptions policies documentation to clarify that the default
configuration in IPS when midstream is enabled is `ignore`, not
`drop-flow`.

Bug OISF#6169
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #9135 (deb9d9d) into master (a3168fd) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9135      +/-   ##
==========================================
- Coverage   82.31%   82.30%   -0.01%     
==========================================
  Files         969      969              
  Lines      273741   273754      +13     
==========================================
- Hits       225329   225324       -5     
- Misses      48412    48430      +18     
Flag Coverage Δ
fuzzcorpus 64.60% <33.33%> (-0.01%) ⬇️
suricata-verify 60.63% <41.66%> (-0.03%) ⬇️
unittests 62.89% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.flow.memuse 592373632 514803280 86.91%

Pipeline 14981

@victorjulien victorjulien deleted the next/61/20230703/v1 branch July 5, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants