detect/byte-jump: Permit variable name for nbytes value #9145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: 6105 This commit adds the ability for nbytes to be a variable when used with the byte_jump keyword.
victorjulien
reviewed
Jul 5, 2023
| * safely cast it when extracting bytes | ||
| */ | ||
| if (data->flags & DETECT_BYTEJUMP_NBYTES_VAR) { | ||
| if (!DetectBytejumpValidateNbytes(data, nbytes)) { |
There was a problem hiding this comment.
If DetectBytejumpValidateNbytes can fail in this path, it will generate errors. If it can't, the check can be removed.
There was a problem hiding this comment.
I can refactor the validate function to only emit an error message when called as part of rule setup.
I think the validation should remain when a variable is used though.
Thoughts @victorjulien ?
There was a problem hiding this comment.
Works for me. As long as we can't get in a path with per packet errors I'm good.
|
WARNING:
Pipeline 14991 |
|
Continued in #9157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #9128
This PR adds the ability to use a variable name with the nbytes value in a
byte_jumpkeyword option list.Link to redmine ticket: 6105
Describe changes:
nbytesin thebyte_jumpoption listUpdates
Provide values to any of the below to override the defaults.
To use a pull request use a branch name like
pr/NwhereNis the pull request number.