next/69/20230705/v1 #9149
Merged
next/69/20230705/v1 #9149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the summary message when Suricata terminates. Without this commit, "nan" was displayed if there were no drops/packets
Issue: 6128 cluster_rollover is no longer permitted; using it will generate a warning message and it'll be replaced with cluster_flow
Issue: 6128 No longer permit rollover/cluster_rollover to be used. Usage will generate a warning message and cluster_flow will be used instead.
Replace implementation of the legacy `filemagic` keyword by the implementation for the `file.magic` variant. This leads to better performance and hooks the rules into the detection engine better. Remove unittests that depended on the old logic. Ticket: OISF#6194.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9149 +/- ##
==========================================
+ Coverage 82.31% 82.33% +0.02%
==========================================
Files 969 968 -1
Lines 273754 273546 -208
==========================================
- Hits 225330 225216 -114
+ Misses 48424 48330 -94
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 15005 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=pr/1288