Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: update x509 crate to v0.8 #9156

Closed

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5439

Describe changes:

  • tls: update x509 crate to v0.8

This is not a backport

On, master, v0.15 is used, but it requires an updated MSRV

Provide values to any of the below to override the defaults.

OISF/suricata-verify#1255

SV_BRANCH=pr/1255

#9152 passing MSRV CI

Ticket: OISF#5439

Fixes cetificate parsing without issuer, and do not require an
update to MSRV.
@jasonish
Copy link
Member

jasonish commented Jul 6, 2023

If we care, cargo audit brings in a new warning:

Crate:     chrono
Version:   0.4.19
Title:     Potential segfault in `localtime_r` invocations
Date:      2020-11-10
ID:        RUSTSEC-2020-0159
URL:       https://rustsec.org/advisories/RUSTSEC-2020-0159
Solution:  Upgrade to >=0.4.20
Dependency tree:
chrono 0.4.19
├── x509-parser 0.8.2
│   └── suricata 6.0.14-dev
└── suricata 6.0.14-dev

This is the exact same reason time currently throws. I think this is acceptable risk for us: https://redmine.openinfosecfoundation.org/issues/5259#note-4.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPW2_autofp_stats_chk
.uptime 221 207 93.67%
SURI_TLPR1_stats_chk
.flow.spare 2181816 2009821 92.12%
.flow.memuse 577437888 1519399808 263.13%

Pipeline 15024

This was referenced Jul 10, 2023
@victorjulien
Copy link
Member

Merged in #9204, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants