Warnint 64to32 6186 v4 #9169
Closed
Warnint 64to32 6186 v4 #9169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
catenacyber
force-pushed
the
warnint-64to32-6186-v4
branch
from
a03a2c3
to
faa0a44
Compare
Ticket: OISF#6186 clang warns and errors on 64 to 32 bits integer conversion
catenacyber
force-pushed
the
warnint-64to32-6186-v4
branch
from
d72c507
to
b3e1427
Compare
|
WARNING:
Pipeline 15074 |
catenacyber
force-pushed
the
warnint-64to32-6186-v4
branch
2 times, most recently
from
3f2c835
to
a71708b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9169 +/- ##
==========================================
- Coverage 82.34% 82.33% -0.02%
==========================================
Files 968 968
Lines 273546 273589 +43
==========================================
+ Hits 225258 225265 +7
- Misses 48288 48324 +36
Flags with carried forward coverage won't be shown. Click here to find out more. |
Ticket: OISF#6186 Warnings about downcast from 64 to 32 bits
catenacyber
force-pushed
the
warnint-64to32-6186-v4
branch
from
a71708b
to
a287216
Compare
|
Information: QA ran without warnings. Pipeline 15176 |
Closed
|
Rebased in #9257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186
Describe changes:
-Wshorten-64-to-32flag to clang after-Wimplicit-int-conversionOISF/libhtp#399
Modifies #9155 with temporary disabling of Terror to get full warnings list
How can I fix the CI about format ? Locally
./scripts/clang-format.sh branchis happy