Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: detect/pcre: Remove shared pcre2 match objects #9241

Closed
wants to merge 4 commits into from

Conversation

jlucovsky
Copy link
Contributor

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:

Describe changes:

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Move pcre2 data structures used for parsing into the detect engine
context, so that multiple tenant loading threads don't use the same
data structures.

Bug: OISF#4797.
@jlucovsky jlucovsky force-pushed the 4797/1 branch 2 times, most recently from 40e8606 to 50d93c4 Compare July 16, 2023 17:53
@suricata-qa
Copy link

WARNING:

field baseline test %
build_asan

Pipeline 15200

@victorjulien
Copy link
Member

detect-config.c:307:9: warning: Branch condition evaluates to a garbage value [core.uninitialized.Branch]
672
    if (match) {
673
        ^~~~~

@victorjulien
Copy link
Member

detect-filestore.c:486:9: warning: Branch condition evaluates to a garbage value [core.uninitialized.Branch]
788
    if (match) {
789
        ^~~~~
790
2 warnings generated.

@jlucovsky jlucovsky force-pushed the 4797/1 branch 3 times, most recently from 3991646 to d67ff40 Compare July 16, 2023 19:13
@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.tcp.overlap 1124925 1221170 108.56%

Pipeline 15201

src/detect-flowint.c Outdated Show resolved Hide resolved
pcre2 is not thread-safe wrt match objects so use locally scoped
objects.

Issue: 4797
@victorjulien
Copy link
Member

replaced by #9242

@victorjulien victorjulien mentioned this pull request Jul 17, 2023
@jlucovsky jlucovsky deleted the 4797/1 branch July 18, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants