Pcre2/v4 #9243
Merged
Pcre2/v4 #9243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move pcre2 data structures used for parsing into the detect engine context, so that multiple tenant loading threads don't use the same data structures. Bug: OISF#4797.
pcre2 is not thread-safe wrt match objects so use locally scoped objects. Issue: 4797
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9243 +/- ##
========================================
Coverage 82.39% 82.40%
========================================
Files 968 968
Lines 273757 273952 +195
========================================
+ Hits 225572 225757 +185
- Misses 48185 48195 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 15205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9242 with fixes