Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/92/60x/20230718/v1 #9249

Merged
merged 6 commits into from
Jul 19, 2023
Merged

next/92/60x/20230718/v1 #9249

merged 6 commits into from
Jul 19, 2023

Conversation

victorjulien
Copy link
Member

victorjulien and others added 6 commits July 14, 2023 10:07
@victorjulien @satta
requirements: use libhtp 0.5.45
cedee76 
(cherry picked from commit ce05511)
@satta
rfb: be more strict parsing the version
66d55a7 
(cherry picked from commit bd1fbf3)
@satta
rfb: add myself as contributor
7a52e39 
(cherry picked from commit 836fff3)
@satta
rfb: never return error on unknown traffic
8f1e08b 
We only try to parse a small subset of what is possible in
RFB. Currently we only understand some standard auth schemes
and stop parsing when the server-client handshake is complete.
Since in IPS mode returning an error from the parser causes
drops that are likely uncalled for, we do not want to return
errors when we simply do not understand what happens in the
traffic. This addresses Redmine OISF#5912.

Bug: OISF#5915.
(cherry picked from commit 1f8a587)
@satta
rfb: ensure logging of incompletely parsed txs
b1d2d78 
(cherry picked from commit 1606aca)
@satta
rfb: also set unimplemented auth types
74cbbd7 
(cherry picked from commit 1521b77)
@victorjulien victorjulien requested review from jasonish and a team as code owners July 18, 2023 19:18
@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.app_layer.flow.rfb 221 244 110.41%
.app_layer.tx.rfb 226 245 108.41%

Pipeline 15300

@victorjulien victorjulien mentioned this pull request Jul 19, 2023
Merged
@victorjulien victorjulien merged commit 74cbbd7 into OISF:master-6.0.x Jul 19, 2023
52 of 54 checks passed
@victorjulien victorjulien deleted the next/92/60x/20230718/v1 branch August 4, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victorjulien @suricata-qa @satta