smb: add smb.version keyword 5075 v3

[jmtaylor90]

Make sure these boxes are signed before submitting your Pull Request -- thank you.

• I have read the contributing guide lines at https://docs.suricata.io/en/latest/devguide/codebase/contributing/contribution-process.html
• I have signed the Open Information Security Foundation contribution agreement at https://suricata.io/about/contribution-agreement/
• I have updated the user guide (in doc/userguide/) to reflect the changes made (if applicable)

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5075

Describe changes:

• used initial authors commits
• removed unnecessary NULL checks
• removed unnecessary debug related function calls

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=https://github.com/OISF/suricata-verify/pull/1380
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

[codecov]

Codecov Report

Merging #9451 (a9ad3bb) into master (185f605) will decrease coverage by 0.01%.
The diff coverage is 90.21%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #9451      +/-   ##
==========================================
- Coverage   82.16%   82.16%   -0.01%     
==========================================
  Files         968      969       +1     
  Lines      274204   274288      +84     
==========================================
+ Hits       225302   225361      +59     
- Misses      48902    48927      +25     

Flag	Coverage Δ
fuzzcorpus	64.06% <26.82%> (-0.03%)	⬇️
suricata-verify	60.87% <87.80%> (-0.02%)	⬇️
unittests	62.88% <36.95%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[catenacyber]

Looks like rebase was not clean enough as CI is red for commit check : we want Suricata to build at every commit to run git bisect

Could you fix this @jmtaylor90 ?

[jmtaylor90]

Yeah, will take a look today and get this sorted. Thanks!

[jmtaylor90]

@catenacyber should I add the change you made in #9462 here as well?

[catenacyber]

should I add the change you made in #9462 here as well?

Not until it is merged, and you may get merged first ;-)

[jmtaylor90]

continued in #9469