Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/200/70x/20231122/v1 #9863

Merged
merged 3 commits into from
Nov 22, 2023
Merged

next/200/70x/20231122/v1 #9863

merged 3 commits into from
Nov 22, 2023

Conversation

victorjulien
Copy link
Member

jufajardini and others added 3 commits November 21, 2023 07:00
@jufajardini
userguide: document flow_id, with examples
16bf5ce 
Flow_id explanation expanded from version shared by Peter Manev.

Task OISF#6445

(cherry picked from commit 58fb559)
@jufajardini
userguide: update tls not_after/not_before mentions
20f9e24 
Our tls fields not_after and not_before are actually logged as
`notafter` and `notbefore`, but were documented with the underscore.

Update the documentation, since updating the log format itself would be
a breaking change.

Task OISF#5494

(cherry picked from commit a649a92)
@jmtaylor90 @victorjulien
doc: update file.data keyword documentation
aae6bea 
Signed-off-by: jason taylor <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #9863 (aae6bea) into main-7.0.x (f6fb48c) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@              Coverage Diff               @@
##           main-7.0.x    #9863      +/-   ##
==============================================
+ Coverage       82.40%   82.49%   +0.09%     
==============================================
  Files             968      968              
  Lines          273870   273870              
==============================================
+ Hits           225688   225942     +254     
+ Misses          48182    47928     -254
Flag Coverage Δ
fuzzcorpus 64.51% <100.00%> (+0.25%) ⬆️
suricata-verify 61.03% <100.00%> (-0.04%) ⬇️
unittests 62.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

lukashino
lukashino approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@lukashino lukashino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 16682

@victorjulien victorjulien merged commit aae6bea into OISF:main-7.0.x Nov 22, 2023
42 checks passed
This was referenced Nov 22, 2023
Merged
Closed
@victorjulien victorjulien deleted the next/200/70x/20231122/v1 branch June 23, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukashino lukashino lukashino approved these changes

@jufajardini jufajardini jufajardini approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@victorjulien @suricata-qa @lukashino @jufajardini @jmtaylor90