Output alert applayer v17.2 #9871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 3827
as fixed patterns can be enough
catenacyber
force-pushed
the
output-alert-applayer-v17.2
branch
4 times, most recently
from
1b2ae39
to
1f08749
Compare
Only implemented for snmp.version and mqtt.password But should be implemented for more
So that we can have dynamically registered protocols. Doing it at compile time, with CFLAGS=-DALPROTO_DYNAMIC_NB=1, allows to keep the rest of the code using ALPROTO_MAX Ticket: 5053
Ticket: 5053
catenacyber
force-pushed
the
output-alert-applayer-v17.2
branch
from
1f08749
to
d993f43
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9871 +/- ##
========================================
Coverage 82.45% 82.45%
========================================
Files 973 962 -11
Lines 273063 272704 -359
========================================
- Hits 225155 224862 -293
+ Misses 47908 47842 -66
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
How can this CI failure be in only one build ? |
catenacyber
force-pushed
the
output-alert-applayer-v17.2
branch
from
d993f43
to
02f2fd6
Compare
|
Retrying CI without latest d993f43 |
|
Information: QA ran without warnings. Pipeline 16707 |
catenacyber
force-pushed
the
output-alert-applayer-v17.2
branch
from
02f2fd6
to
580bb9c
Compare
|
WARNING:
Pipeline 16710 |
This was referenced Apr 26, 2024
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine tickets:
https://redmine.openinfosecfoundation.org/issues/3827
https://redmine.openinfosecfoundation.org/issues/5053
Describe changes:
#9812 rebased
OISF/suricata-verify#1490