Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust/sip: register parser for tcp v9 #9893

Closed
wants to merge 8 commits into from
Closed

rust/sip: register parser for tcp v9 #9893

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5451fdb
rust/sip: rustfmt sip module
glongo Aug 14, 2023
961a62d
sip/parser: accept valid chars
glongo Aug 1, 2023
add724d
sip/parser: enforce valid chars for sip version
glongo Nov 25, 2023
a4f7db1
rust/sip: register parser for tcp
glongo Aug 1, 2023
c49e208
rust/sip: add direction to transaction
glongo Aug 1, 2023
96b34a7
suricata.yaml: define SIP_PORTS
glongo Aug 1, 2023
fbb6c7a
rust/sip: register pattern matching
glongo Nov 24, 2023
769de02
doc: add upgrade section for 8
glongo Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions doc/userguide/upgrade.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,18 @@ also check all the new features that have been added but are not covered by
this guide. Those features are either not enabled by default or require
dedicated new configuration.

Upgrading 7.0 to 8.0
--------------------
- SIP parser has been updated to inspect traffic carried by TCP as well.
SIP keywords can still match on their respective fields in addition
to these improvements.
Transactions are logged with the same schema regardless of which
transport protocol is carrying the payload.
Also, SIP protocol is detected using pattern matching and not only
probing parser.
- ``SIP_PORTS`` variable has been introduced in suricata.yaml
- Application layer's ``sip`` counter has been split into ``sip_tcp`` and ``sip_udp``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should mention that this is for the stats events.
cc @jufajardini

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!


Upgrading 6.0 to 7.0
--------------------

Expand Down
Loading