Experiment ac rust/v4 #9902
Closed
Experiment ac rust/v4 #9902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid redundant pointer checks; instead check once.
Count uniq matches only, like the Hyperscan implementation. Ticket: OISF#3847.
victorjulien
commented
Nov 27, 2023
Closed
jasonish
reviewed
Nov 27, 2023
jasonish
reviewed
Nov 27, 2023
Comment on lines
+219
to
+220
| let p = unsafe { build_slice!(pat, pat_len as usize) }; | ||
| let s = unsafe { build_slice!(sids, sids_len as usize) }; |
There was a problem hiding this comment.
yeah, this is a left over from when clippy adviced to mark the function unsafe, even though the compiler didn't require it. It feels odd to make the function unsafe while the unsafe parts are more limited. I would like rust to consider the other parts safe and be strict in its checks.
|
replaced by #9904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9896 with some fixes and updated the match loop to only count unique matches.
Still have to do benchmarks.
Experiment to see if we can use aho-corasick Rust crate for our MPM.
https://redmine.openinfosecfoundation.org/issues/3847
TODOs