Enip rust 3958 v6 #9940
Closed
Enip rust 3958 v6 #9940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can write enip.revision: 0x203
catenacyber
requested review from
jasonish,
jufajardini,
victorjulien and
a team
as code owners
Closed
catenacyber
force-pushed
the
enip-rust-3958-v6
branch
from
ae82e44
to
af2699d
Compare
Ticket: 3958
- enip_command keyword accepts now string enumeration as values.
- transactions are now bidirectional
- there is a logger
- gap support is improved with probing for resync
- SEQUENCE_ADDR_ITEM value is fixed to 0x8002 instead of 0xB002
- frames support
- app-layer events
- add enip.status keyword
- add identity keywords :
enip.product_name, enip.protocol_version, enip.revision,
enip.identity_status, enip.state, enip.serial, enip.product_code,
enip.device_type, enip.vendor_id, enip.capabilities,
enip.cip_attribute, enip.cip_class, enip.cip_instance,
enip.cip_status, enip.cip_extendedstatus
catenacyber
force-pushed
the
enip-rust-3958-v6
branch
from
af2699d
to
5e86426
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9940 +/- ##
==========================================
- Coverage 82.35% 81.67% -0.68%
==========================================
Files 972 991 +19
Lines 273060 275471 +2411
==========================================
+ Hits 224870 224989 +119
- Misses 48190 50482 +2292
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 16843 |
This was referenced Dec 7, 2023
Closed
|
Replaced by #9991 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3958
Describe changes:
Alon the way, also
#9937 +
This is complete but missing S-V tests
Provide values to any of the below to override the defaults.
OISF/suricata-verify#1485