pgsql: use static str for log & remove whitespaces - v1 #9968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the white spaces from the password message, as these can cause issues with grepping commands querying log results, and also doesn't show a consistent behavior among different environments. Also replace function call with static str, as it wasn't needed there.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9968 +/- ##
==========================================
+ Coverage 82.39% 82.41% +0.02%
==========================================
Files 970 970
Lines 271359 271359
==========================================
+ Hits 223586 223646 +60
+ Misses 47773 47713 -60
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 16879 |
|
Something to consider, why log anything at all if password logging is disabled? |
Indeed xD I think the idea that I had was to inform that it wasn't there due to config, but since this is something only from our end, I see that it would make sense to remove, indeed. |
|
Replaced by: #9979 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the white spaces from the password message, as these can cause issues with grepping commands querying log results, and also doesn't show a consistent behavior among different environments.
Also replace function call with static str, as it wasn't needed there.
Link to redmine ticket:
None yet, will create one if we decide we want to merge and backport this
Describe changes:
to_str()with static string in logging call_as it's more query friendlySV_BRANCH=OISF/suricata-verify#1511