-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect cleanups/v6 #9986
Closed
Closed
Detect cleanups/v6 #9986
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e19f162
detect/content-inspect: reduce scope of variables
victorjulien 5ed3d74
detect/content-inspect: pass const to inspect func
victorjulien 0ebfcd3
detect/content-inspect: remove const casting
victorjulien 4d43fe7
detect/content-inspect: assist branch prediction
victorjulien 159ec36
detect/content-inspect: switch type of enum
victorjulien e9ec240
detect/content-inspect: add entry for InspectionBuffer
victorjulien b2e782b
detect/dns.query: use new content inspect entry
victorjulien 521f04a
detect/krb5.sname: use new content inspect entry
victorjulien aee5aa3
detect/base64: move content inspection logic
victorjulien 94fd401
detect/content-inspect: reduce scope of internal func
victorjulien 895338c
detect/content-inspect: localize recursion counting
victorjulien d481537
detect/content-inspect: flatten branches
victorjulien ff5f17f
detect/isdataat: optimize recursion mismatches
victorjulien 1ee360d
detect/payload: remove unneeded pointer reset
victorjulien 8cbf4fa
detect/bytemath: pass match ctx directly
victorjulien 461b84c
detect: optimize struct layout
victorjulien 36100bc
detect/content-inspect: optimize struct layout
victorjulien 50e5666
detect/content-inspect: improve header docs
victorjulien File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: unnecessary else