Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hand events #440

Merged
merged 4 commits into from
Aug 18, 2024
Merged

Fix hand events #440

merged 4 commits into from
Aug 18, 2024

Conversation

jimchen5209
Copy link
Member

@jimchen5209 jimchen5209 commented Aug 17, 2024 •
edited
Loading

Changes

  • fix player should be able to harvest when hands are empty whenever player is sneaking
  • fix hand not swing when spinning custom block
  • Workaround disable post state update for bell

Related

@jimchen5209 jimchen5209 added status: needs testing This pr needs testing status: needs review This pr needs review system: galaxy labels Aug 17, 2024
@jimchen5209 jimchen5209 changed the title fix: player should be able to harvest when hands are empty Fix hand events Aug 17, 2024
@jimchen5209 jimchen5209 added the type: bug Something isn't working label Aug 17, 2024
bill96012
bill96012 approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@bill96012 bill96012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed

@jimchen5209
Copy link
Member Author

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 18, 2024

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit c6c614f into master Aug 18, 2024
8 checks passed
@mergify mergify bot deleted the fix-harvest branch August 18, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james58899 james58899 james58899 approved these changes

@bill96012 bill96012 bill96012 approved these changes

Assignees
No one assigned
Labels
status: needs review This pr needs review status: needs testing This pr needs testing system: galaxy type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

空手蹲下時應可以右鍵採收 Wrench spin of bell broken when block nearby
3 participants
@jimchen5209 @james58899 @bill96012