Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GUI block entity binding #441

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Add GUI block entity binding #441

merged 3 commits into from
Aug 18, 2024

Conversation

james58899
Copy link
Member

fix #439

@james58899 james58899 added type: bug Something isn't working system: GUI labels Aug 17, 2024
jimchen5209
jimchen5209 approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@jimchen5209 jimchen5209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review passed

Looks good

@jimchen5209 jimchen5209 added the status: needs testing This pr needs testing label Aug 18, 2024
bill96012
bill96012 approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@bill96012 bill96012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed

@mergify mergify bot merged commit 0b4b104 into master Aug 18, 2024
8 checks passed
@mergify mergify bot deleted the fix-gui-close branch August 18, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimchen5209 jimchen5209 jimchen5209 approved these changes

@bill96012 bill96012 bill96012 approved these changes

Assignees
No one assigned
Labels
status: needs testing This pr needs testing system: GUI type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

自訂方塊拆除時不會關閉介面而且可以繼續互動
3 participants
@james58899 @jimchen5209 @bill96012