[refactor] querydsl 및 프로젝션 적용 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkdwns414
approved these changes
Jan 12, 2025
Comment on lines
-213
to
-239
|
|
||
| private ParticipantDto createParticipantDto(final ParticipantStatusUserInfoDto dto) { | ||
| String state = determineState(dto.preparationAt(), dto.departureAt(), dto.arrivalAt()); // 상태 결정 로직 호출 | ||
|
|
||
| return ParticipantDto.of(dto.participantId(), dto.memberId(), dto.name(), dto.profileImg(), state); | ||
| } | ||
|
|
||
| private String determineState( | ||
| final LocalDateTime preparationAt, | ||
| final LocalDateTime departureAt, | ||
| final LocalDateTime arrivalAt | ||
| ) { | ||
| if (arrivalAt != null) { | ||
| return "도착"; | ||
| } else if (departureAt != null) { | ||
| return "이동중"; | ||
| } else if (preparationAt != null) { | ||
| return "준비중"; | ||
| } | ||
| return "꾸물중"; | ||
| } | ||
|
|
||
| private int stateOrder(String state) { | ||
| switch(state) { | ||
| case "도착": return 1; | ||
| case "이동중": return 2; | ||
| case "준비중": return 3; |
There was a problem hiding this comment.
DB에서 처리돼서 오는거긴 하지만 보이는 코드는 깔끔해졌네용
There was a problem hiding this comment.
넵 기존 애플리케이션으로 가져와 처리하는 것보다 DB에서 처리하는 게 성능적인 이점과 코드 가독성 면에서 더 나은 방식이라고 판단하여 수정해보았습니다!
Comment on lines
+21
to
+28
| SELECT | ||
| m.id as id, m.name as name, m.createdAt as createdAt, | ||
| m.invitationCode as invitationCode, COUNT(p.id) as metCount | ||
| FROM Meeting m | ||
| LEFT JOIN Promise p ON p.meeting.id = m.id AND p.isCompleted = true | ||
| WHERE m.id = :meetingId | ||
| GROUP BY m.id """) | ||
| Optional<MeetingMetCountDto> findByIdWithMetCount(Long meetingId); | ||
| Optional<MeetingMetCountProjection> findByIdWithMetCount(Long meetingId); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Uncompleted Tasks 😅
To Reviewers 📢