fix/#162 진웅오빠 코드리뷰 반영

OMZigak · Jul 12, 2024 · 33f253b · 33f253b
1 parent a10f519
commit 33f253b
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 12 deletions.
diff --git a/KkuMulKum/Application/SceneDelegate.swift b/KkuMulKum/Application/SceneDelegate.swift
@@ -18,7 +18,7 @@ class SceneDelegate: UIResponder, UIWindowSceneDelegate {
     ) {
         guard let windowScene = (scene as? UIWindowScene) else { return }
         self.window = UIWindow(windowScene: windowScene)
-        self.window?.rootViewController = MainTabBarController()
+        self.window?.rootViewController = LoginViewController()
         self.window?.makeKeyAndVisible()
     }
 

diff --git a/KkuMulKum/Source/MeetingList/Cell/MeetingTableViewCell.swift b/KkuMulKum/Source/MeetingList/Cell/MeetingTableViewCell.swift
@@ -15,10 +15,7 @@ final class MeetingTableViewCell: BaseTableViewCell {
 
     // MARK: - Property
 
-    var itemRow: Int?
-
-    private let cellView = UIView().then {
-        $0.backgroundColor = .white
+    private let cellView = UIView(backgroundColor: .white).then {
         $0.layer.cornerRadius = 8
     }
 
@@ -34,9 +31,7 @@ final class MeetingTableViewCell: BaseTableViewCell {
     // MARK: - UI Setting
 
     override func setupView() {
-        self.do {
-            $0.backgroundColor = .clear
-        }
+        self.backgroundColor = .clear
         addSubviews(cellView, nameLabel, countLabel, rightIcon)
     }
 

diff --git a/KkuMulKum/Source/MeetingList/View/MeetingListView.swift b/KkuMulKum/Source/MeetingList/View/MeetingListView.swift
@@ -45,7 +45,6 @@ final class MeetingListView: BaseView {
         $0.backgroundColor = .clear
         $0.showsVerticalScrollIndicator = false
         $0.separatorStyle = .none
-        header.frame = CGRect(x: 0, y: 0, width: UIScreen.main.bounds.width, height: 170)
         $0.tableHeaderView = header
     }
 
@@ -80,5 +79,11 @@ final class MeetingListView: BaseView {
             $0.leading.trailing.equalToSuperview().inset(20)
             $0.top.bottom.equalToSuperview()
         }
+
+        header.snp.makeConstraints {
+            $0.top.equalToSuperview()
+            $0.width.equalTo(UIScreen.main.bounds.width)
+            $0.height.equalTo(Screen.height(170))
+        }
     }
 }
diff --git a/KkuMulKum/Source/MeetingList/ViewController/MeetingListViewController.swift b/KkuMulKum/Source/MeetingList/ViewController/MeetingListViewController.swift
@@ -28,9 +28,7 @@ class MeetingListViewController: BaseViewController {
         super.viewDidLoad()
 
         view.backgroundColor = .gray0
-        setupView()
         register()
-        setupDelegate()
 
         updateMeetingList()
         viewModel.dummy()
@@ -86,7 +84,7 @@ class MeetingListViewController: BaseViewController {
 
 extension MeetingListViewController: UITableViewDelegate {
     func tableView(_ tableView: UITableView, heightForRowAt indexPath: IndexPath) -> CGFloat {
-        return 88
+        return Screen.height(88)
     }
 }