[feat] 내 모임 리스트 UI 구현 #165
Conversation
| $0.setText("모임 추가하기", style: .body05, color: .green3) | ||
| } | ||
|
|
||
| private let addIcon = UIImageView().then { |
There was a problem hiding this comment.
네이밍의 끝은 어떤 프로퍼티인지로 하기로 해서 addIconImageView면 더 좋지 않을까요 ??
There was a problem hiding this comment.
icon 정도는 이렇게 해도 될 거라고 생각하긴 했는데 흠// 반영하겠습니다
| rootView.tableView.dataSource = self | ||
| } | ||
|
|
||
| private func updateMeeingList() { |
| @@ -18,7 +18,7 @@ class SceneDelegate: UIResponder, UIWindowSceneDelegate { | |||
| ) { | |||
| guard let windowScene = (scene as? UIWindowScene) else { return } | |||
| self.window = UIWindow(windowScene: windowScene) | |||
| self.window?.rootViewController = NicknameViewController() | |||
| self.window?.rootViewController = MainTabBarController() | |||
There was a problem hiding this comment.
앗 바꾼다고 하고 암생각없이 올려버렷네요 미안합니다~
| addButton.snp.makeConstraints { | ||
| $0.top.equalTo(infoLabel.snp.bottom).offset(16) | ||
| $0.leading.trailing.equalToSuperview() | ||
| $0.height.equalTo(48) |
| lineView.snp.makeConstraints { | ||
| $0.leading.trailing.equalToSuperview() | ||
| $0.bottom.equalTo(navigationController?.navigationBar.snp.bottom ?? 0) | ||
| $0.height.equalTo(1) |
| import Then | ||
|
|
||
| final class MeetingListViewModel { | ||
| var meetingListData = ObservablePattern<[MeetingDummyModel]>(MeetingDummyModel.dummy()) |
| self.do { | ||
| $0.backgroundColor = .clear | ||
| } |
There was a problem hiding this comment.
backgroundColor = .clear 로 해도 좋을 것 같아요.
|
|
||
| var itemRow: Int? | ||
|
|
There was a problem hiding this comment.
이것은 불필요한 걸까요?
필요하다면, 왜 존재해야 한 것일까요?
There was a problem hiding this comment.
아까 함수 수정하면서 삭제를 안 했네용 .. ㅎㅎ 머쓱
| private let cellView = UIView().then { | ||
| $0.backgroundColor = .white |
There was a problem hiding this comment.
backgroundColor를 이용하여 생성할 수 있습니다.
| $0.separatorStyle = .none | ||
| header.frame = CGRect(x: 0, y: 0, width: UIScreen.main.bounds.width, height: 170) |
There was a problem hiding this comment.
header를 frame으로 설정한 이유가 궁금합니다.
There was a problem hiding this comment.
width를 leading.trailing.equalToSuperview()로 잡으니 오류가 나서 UIScreen.main.bounds.width로 width를 잡아주었는데요.. 현재는 setupAutoLayout() 함수로 분리해둔 상태입니다.
header.snp.makeConstraints {
$0.top.equalToSuperview()
$0.width.equalTo(UIScreen.main.bounds.width)
$0.height.equalTo(Screen.height(170))
}
| // MARK: - Property | ||
|
|
||
| private let rootView = MeetingListView() | ||
| private let viewModel = MeetingListViewModel() |
There was a problem hiding this comment.
viewModel을 생성자에서 DI하지 않은 이유가 궁금합니다.
| view.backgroundColor = .gray0 | ||
| setupView() | ||
| register() | ||
| setupDelegate() |
There was a problem hiding this comment.
setupView, setupDelegate는 viewDidLoad에서 부르지 않아도 됩니다.
| func tableView(_ tableView: UITableView, heightForRowAt indexPath: IndexPath) -> CGFloat { | ||
| return 88 | ||
| } |
There was a problem hiding this comment.
여기는 Screen 코드를 써도 좋을 것 같습니다.
🔗 연결된 이슈
📄 작업 내용