[feat] 준비 현황 뷰 구현 #186
Merged
[feat] 준비 현황 뷰 구현 #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: KkuMulKum.xcodeproj/project.pbxproj
Conflicts: KkuMulKum.xcodeproj/project.pbxproj KkuMulKum/Source/Onboarding/Login/ViewController/LoginViewController.swift
Closed
4 tasks
mmaybei
approved these changes
Jul 16, 2024
| } | ||
| let participantId, memberId: Int | ||
| let name, state: String | ||
| let profileImg: String? |
There was a problem hiding this comment.
profileImageURL로 코딩키를 만들어주는 게 다른 모델과도 통일성있을 것 같아요!
|
|
||
| struct Comer: Codable { | ||
| let participantId: Int | ||
| let name, profileImg: String |
|
|
||
| struct Comer: Codable { | ||
| let participantId: Int | ||
| let name, profileImg: String |
There was a problem hiding this comment.
엇... 이 파일은 삭제되어야 하는데 깜빡했어요 감사합니다 !!
Comment on lines
+17
to
+27
| func getMyPromiseStatus(with promiseID: Int) -> MyReadyStatusModel? { | ||
| let mockData = MyReadyStatusModel( | ||
| preparationTime: 300, | ||
| travelTime: 230, | ||
| preparationStartAt: "AM 11:00", | ||
| departureAt: "PM 1:30", | ||
| arrivalAt: "PM 2:00" | ||
| ) | ||
|
|
||
| return mockData | ||
| } |
JinUng41
approved these changes
Jul 16, 2024
| let id, dDay: Int | ||
| let promiseId, dDay: Int |
There was a problem hiding this comment.
CodingKey를 사용해서 저희 컨벤션에 맞게 promiseID로 수정해도 좋을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 연결된 이슈
📄 작업 내용