[Feat] 서비스 타입 구현 #192
Merged
[Feat] 서비스 타입 구현 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
JinUng41
approved these changes
Jul 16, 2024
Comment on lines
22
to
27
| let service: InviteCodeServiceType | ||
| let inviteCode = ObservablePattern<String>("") | ||
| let inviteCodeState = ObservablePattern<InviteCodeState>(.empty) | ||
| let isNextButtonEnabled = ObservablePattern<Bool>(false) | ||
|
|
||
| private let service: InviteCodeServiceType | ||
|
|
There was a problem hiding this comment.
service를 ViewModel 외부에서 접근가능하게 선언하신 이유가 궁금하네요?
There was a problem hiding this comment.
사실 막연하게 쓸 일이 있을 것 같아서 일단 바꿔놨는데 생각해보니 필요가 없네요 ,,, 감사합니다!
Comment on lines
14
to
16
|
|
||
| let tardyService: MockTardyService | ||
| var isPastDue: ObservablePattern<Bool> |
There was a problem hiding this comment.
tardyServiceType을 주입받으면 어땠을까 하는..
Comment on lines
10
to
13
| protocol PromiseInfoServiceType { | ||
| func getPromiseInfo(with promiseId: Int) -> PromiseInfoModel? | ||
| } | ||
|
|
There was a problem hiding this comment.
저는 get보다는 fetch를 더 많이 사용합니다.
그냥 그렇다구요
Conflicts: KkuMulKum.xcodeproj/project.pbxproj
hooni0918
approved these changes
Jul 16, 2024
|
|
||
| // MARK: Initialize | ||
|
|
||
| init(service: CreateMeetingServiceType) { | ||
| self.service = service | ||
| init(createMeetingService: CreateMeetingServiceType) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 연결된 이슈
📄 작업 내용