-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] 최종 qa 반영 #389
[Fix] 최종 qa 반영 #389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다.
앱델이나 신델의 경우, 구현 중인 코드라고 말씀해 주셨는데, 최종 QA 전에 더 반영되어야 하는 내용이 있는지 또는 앞으로 더 수정되어야 할 부분이 있는지 알려주시면 좋을 것 같습니다.
@@ -62,6 +64,13 @@ class AppDelegate: UIResponder, UIApplicationDelegate { | |||
_ application: UIApplication, | |||
didDiscardSceneSessions sceneSessions: Set<UISceneSession> | |||
) {} | |||
|
|||
func application(_ application: UIApplication, didReceiveRemoteNotification userInfo: [AnyHashable : Any], fetchCompletionHandler completionHandler: @escaping (UIBackgroundFetchResult) -> Void) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분은 개행하면 어떨까용?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appdelegate / Scenedelegate에 있는 코드는 그냥 섞여있는 코드이고 구현중인 코드이니 무시하고 리뷰해주세요
func userNotificationCenter(_ center: UNUserNotificationCenter, | ||
willPresent notification: UNNotification, | ||
withCompletionHandler completionHandler: @escaping (UNNotificationPresentationOptions) -> Void) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
개행하니까 너무 읽기 좋은데, 괄호 앞 뒤로 개행했으면 좋겠습니다.
해당 부분을 드래그 후, ctrl + m 눌러보시면 바로 이해하실 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appdelegate / Scenedelegate에 있는 코드는 그냥 섞여있는 코드이고 구현중인 코드이니 무시하고 리뷰해주세요
func userNotificationCenter(_ center: UNUserNotificationCenter, | ||
didReceive response: UNNotificationResponse, | ||
withCompletionHandler completionHandler: @escaping () -> Void) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분도 괄호 앞 뒤로 개행 부탁드려요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appdelegate / Scenedelegate에 있는 코드는 그냥 섞여있는 코드이고 구현중인 코드이니 무시하고 리뷰해주세요
var pendingNotificationData: [String: Any]? | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 변수는 무엇을 위한 건가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appdelegate / Scenedelegate에 있는 코드는 그냥 섞여있는 코드이고 구현중인 코드이니 무시하고 리뷰해주세요
guard let screen = data["screen"] as? String, | ||
let promiseId = data["promiseId"] as? Int else { | ||
return | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else 개행 부탁드립니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appdelegate / Scenedelegate에 있는 코드는 그냥 섞여있는 코드이고 구현중인 코드이니 무시하고 리뷰해주세요
private func setupImagePicker() { | ||
imagePicker.delegate = self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delegate는 setupDelegate에서 설정해도 좋을 듯 합니다.
alert.addAction(UIAlertAction(title: "설정", style: .default) { _ in | ||
if let settingsURL = URL(string: UIApplication.openSettingsURLString) { | ||
UIApplication.shared.open(settingsURL) | ||
} | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿! 수고하셨습니당
🔗 연결된 이슈
📄 작업 내용
👀 기타 더 이야기해볼 점
알람 클릭시 내 모임으로 이동하는 건 아직 구현을 못햇습니다. fcm에 대한 이해가 우선되어야 할것같아서 공부중이에요
appdelegate / Scenedelegate에 있는 코드는 그냥 섞여있는 코드이고 구현중인 코드이니 무시하고 리뷰해주세요