[7.6.0][CDE] ApiStroke.ToJSON check #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askonev
requested changes
Dec 5, 2023
askonev
requested changes
Dec 5, 2023
askonev
force-pushed
the
feature/all_object_to_json
branch
2 times, most recently
from
98ed4b7 to
7a1cee5
Compare
Yar04ek
force-pushed
the
feature/api_stroke_to_json
branch
4 times, most recently
from
7220336 to
59ea04f
Compare
askonev
requested changes
Dec 13, 2023
askonev
requested changes
Dec 13, 2023
askonev
requested changes
Dec 14, 2023
askonev
requested changes
Dec 14, 2023
Yar04ek
force-pushed
the
feature/api_stroke_to_json
branch
from
c37cf1c to
03fb2d1
Compare
askonev
requested changes
Dec 18, 2023
askonev
requested changes
Dec 19, 2023
spec/docx/smoke/api_stroke_spec.rb
Outdated
| expect(OoxmlParser::Color.new(stroke['fill']['fill']['color']['color']['rgba']['red'], | ||
| stroke['fill']['fill']['color']['color']['rgba']['green'], | ||
| stroke['fill']['fill']['color']['color']['rgba']['blue']).to_hex.to_sym) | ||
| .to eq(OoxmlParser::Color.new(51, 51, 51).to_hex.to_sym) |
There was a problem hiding this comment.
I think the conversion to hex of the color object is not required, since we are comparing two color objects, not an color object and a string\symbol
Try using expect(smt).to eql(smt)
a.eql?(b) # object equivalence - a and b have the same value
d67fc6a to
f2d93f3
Compare
askonev
force-pushed
the
feature/api_stroke_to_json
branch
3 times, most recently
from
013e012 to
95f0208
Compare
askonev
approved these changes
Jan 19, 2024
askonev
force-pushed
the
feature/api_stroke_to_json
branch
from
95f0208 to
fa5aea8
Compare
askonev
requested review from
alinasafonova
and removed request for
alinasafonova
alinasafonova
approved these changes
Jan 22, 2024
askonev
pushed a commit
that referenced
this pull request
Feb 27, 2024
* feature: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * feature: ApiStroke.ToJSON * feature: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON
askonev
pushed a commit
that referenced
this pull request
Mar 25, 2024
* feature: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * feature: ApiStroke.ToJSON * feature: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON
askonev
pushed a commit
that referenced
this pull request
Apr 9, 2024
* feature: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * feature: ApiStroke.ToJSON * feature: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON
askonev
pushed a commit
that referenced
this pull request
Jun 11, 2024
* feature: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * feature: ApiStroke.ToJSON * feature: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON
askonev
pushed a commit
that referenced
this pull request
Jun 13, 2024
* feature: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * feature: ApiStroke.ToJSON * feature: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON
askonev
pushed a commit
that referenced
this pull request
Jun 14, 2024
* feature: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * feature: ApiStroke.ToJSON * feature: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON
askonev
added a commit
that referenced
this pull request
Jun 18, 2024
* Paragraph to json * Run to json * * Hyperlink to json * Range to json * * DocContent to json * * Table to json * [ref] ref api_hyperlink/to_json.js * * Style to json * [ref] DocContent to json * [ref] DocContent. BlockLvlSdt & Table check * ref: yardoc fix rule * fix: unify static data for specs * fix: ApiDocumentContent.ToJSON expected custom name * [7.6.0][CDE] ApiRGBColor.ToJSON check (#997) * feature: Fill.ToJSON (#1008) * revert: TestData (#1009) * [7.6.0][CDE] ApiUniColor.ToJSON check (#1015) * feature: ApiUniColor.ToJSON * ref: ApiUniColor.ToJSON * ref: ApiUniColor.ToJSON * ref: ApiUniColor.ToJSON * ref: ApiUniColor.ToJSON * [7.6.0][CDE] ApiGradientStop.ToJSON check (#1014) * feature: ApiGradientStop.ToJSON * ApiGradientStop.ToJSON * [7.6.0][CDE] ApiStroke.ToJSON check (#1010) * feature: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * feature: ApiStroke.ToJSON * feature: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * ref: ApiStroke.ToJSON * [8.0.0][CDE] Document.ToJSON * [8.1][CDE] InlineLvlSdt.ToJSON * fix: 66725 * fix: ApiTable.ToJSON * [8.1][CDE] BlockLvlSdt.ToJSON() * [8.1][CDE] TablePr.ToJSON() * [8.1][CDE] TableRowPr.ToJSON() * [8.1][CDE] TableCellPr.ToJSON() * [8.1][CDE] TableStylePr.ToJSON() * [8.1][CDE] TableCell.ToJSON() * [8.1][CDE] TableRow.ToJSON() * [8.1][CDE] Drawing.ToJSON() * [8.1][CDE] SchemeColor.ToJSON() * [8.1][CDE] ApiPresetColor.ToJSON() * Revert "[8.1][CDE] BlockLvlSdt.ToJSON()" This reverts commit 68db03d. * [8.1][CDE] ApiParaPr.ToJSON() * [8.1] remove doc-builder-static-data * [8.1] skip renamed CDE style * ref: default_styles order & doc_builder_testing require order * info: coverage --------- Co-authored-by: Yarosalv Maslov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.