Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init shape var & skip CDE CreateImage for heisenbug reason #1101

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

askonev
Copy link
Member

@askonev askonev commented Apr 17, 2024

In github Actions, the test crash is repeated regularly but not always (heisenbug). The error does not occur on a clean machine and docker container with limits on cpu and memory. It is also reproduced if you install a base64 image, which means that these are not network problems.

Failures:

  1) Api section tests Api | CreateImage method
     Failure/Error: expect(drawing.graphic.data.path_to_image.file_reference.content.length).to be > 1000

     NoMethodError:
       undefined method `length' for nil:NilClass
     # ./spec/docx/smoke/api_base_spec.rb:52:in `block (2 levels) in <top (required)>'
docker run --name 1g1cpu \
            --cpus="1" \
            --memory=1g \
            --memory-swap 0 \
           test

I will update ruby to 3.2.2 for centos and repeat the tests

@askonev askonev force-pushed the fix/create_image branch 5 times, most recently from ec6df17 to f2b6adb Compare April 17, 2024 14:50
@askonev askonev changed the title fix: init shape var fix: init shape var & skip CDE CreateImage for heisenbug reason Apr 17, 2024
@askonev askonev requested a review from alinasafonova April 17, 2024 16:37
@askonev askonev merged commit 289d923 into master Apr 18, 2024
8 checks passed
@askonev askonev deleted the fix/create_image branch April 18, 2024 11:05
@VitaliySerov
Copy link
Member

I will update ruby to 3.2.2 for centos and repeat the tests

@askonev BTW this is not an easy task - it's currently blocked by this:

#1029

I've pushed the code to 3rdparty repo to provide those builds, but seems no one cares

@askonev
Copy link
Member Author

askonev commented Apr 19, 2024

@VitaliySerov Yes, I saw that the repository maintainer stopped actively supporting the project.

A simple solution would be to install the latest beta version that is available
ruby-3.2.2-1.el7.centos.x86_64.rp

And then look for a solution

@VitaliySerov
Copy link
Member

@askonev Right now we're usinng 3.2.0:

https://github.com/ONLYOFFICE/doc-builder-testing/blob/master/dockerfiles/centos-7/Dockerfile#L5

it can be update for latest avialabe build v3.2.2-1 - without any problems
Actually I think you should do it :)

But if we need to update to latest ruby 3.3 it will be a problem right now, yeah

@askonev
Copy link
Member Author

askonev commented Apr 19, 2024

@VitaliySerov The repository may not be able to continue working because support for CentOS Stream 8 and CentOS Linux 7 ends on May 31, 2024.

CentOS Linux 7 EOL: 2024-06-30
CentOS Linux 8 EOL: 2021-12-31
CentOS Stream 8 EOL: 2024-05-31
CentOS Stream 9 EOL: 2027-05-31

I think the task of migrating to CentOS Stream 9 of our tests will solve the problem with migrating to ruby 3.3.*

https://blog.centos.org/2023/04/end-dates-are-coming-for-centos-stream-8-and-centos-linux-7/
https://centos.pkgs.org/9-stream/centos-appstream-x86_64/ruby-3.3.0-1.module_el9+862+220991ec.x86_64.rpm.html

@VitaliySerov
Copy link
Member

Yep, probably migrate tests to centos 9 stream is good idea

I think centos 7 will be alive for long years again but seems you're right it's like 2 months until EOL, wow how time goes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants