Bump rubocop from 1.28.2 to 1.57.1 (#116)

* Bump rubocop from 1.28.2 to 1.57.1 Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.28.2 to 1.57.1. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.28.2...v1.57.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Fix severl issues with newer Rubocop --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ONLYOFFICE Testing Robot <[email protected]>
ONLYOFFICE-QA · Oct 13, 2023 · 24cabaa · 24cabaa
1 parent 762d14a
commit 24cabaa
Show file tree

Hide file tree

Showing 8 changed files with 35 additions and 19 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2022-02-18 18:25:33 UTC using RuboCop version 1.25.1.
+# on 2023-10-13 10:00:24 UTC using RuboCop version 1.57.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new

diff --git a/Gemfile b/Gemfile
@@ -3,3 +3,17 @@
 source 'https://rubygems.org'
 
 gemspec
+
+group :test do
+  gem 'rspec', '~> 3'
+  gem 'simplecov', '~> 0', require: false
+end
+
+group :development do
+  gem 'overcommit', '~> 0', require: false
+  gem 'rubocop', '~> 1'
+  gem 'rubocop-performance', '~> 1'
+  gem 'rubocop-rake', '~> 0'
+  gem 'rubocop-rspec', '~> 2'
+  gem 'yard', '>= 0.9.20', require: false
+end
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -8,10 +8,13 @@ GEM
   remote: https://rubygems.org/
   specs:
     ast (2.4.2)
+    base64 (0.1.1)
     childprocess (4.1.0)
     diff-lcs (1.5.0)
     docile (1.4.0)
     iniparse (1.5.0)
+    json (2.6.3)
+    language_server-protocol (3.17.0.3)
     overcommit (0.60.0)
       childprocess (>= 0.6.3, < 5)
       iniparse (~> 1.4)
@@ -38,15 +41,18 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
     rspec-support (3.12.1)
-    rubocop (1.28.2)
+    rubocop (1.57.1)
+      base64 (~> 0.1.1)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.1.0.0)
+      parser (>= 3.2.2.4)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.17.0, < 2.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.28.1, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
+      unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.29.0)
       parser (>= 3.2.1.0)
     rubocop-performance (1.19.1)
@@ -81,4 +87,4 @@ DEPENDENCIES
   yard (>= 0.9.20)
 
 BUNDLED WITH
-   2.3.7
+   2.4.20
diff --git a/onlyoffice_rake_code_linter.gemspec b/onlyoffice_rake_code_linter.gemspec
@@ -24,12 +24,4 @@ Gem::Specification.new do |s|
   s.files = Dir['lib/**/*']
   s.license = 'AGPL-3.0'
   s.add_runtime_dependency('rake', '~> 13')
-  s.add_development_dependency('overcommit', '~> 0')
-  s.add_development_dependency('rspec', '~> 3')
-  s.add_development_dependency('rubocop', '~> 1')
-  s.add_development_dependency('rubocop-performance', '~> 1')
-  s.add_development_dependency('rubocop-rake', '~> 0')
-  s.add_development_dependency('rubocop-rspec', '~> 2')
-  s.add_development_dependency('simplecov', '~> 0')
-  s.add_development_dependency('yard', '>= 0.9.20')
 end
diff --git a/spec/onlyoffice_rake_code_linter/onlyoffice_rake_code_linter_file_without_address_spec.rb b/spec/onlyoffice_rake_code_linter/onlyoffice_rake_code_linter_file_without_address_spec.rb
@@ -7,6 +7,7 @@
   end
 
   it 'do not raise error on file with address' do
-    described_class.file_without_address(path: "#{Dir.pwd}/spec/test_files/good/file_with_address/*.js")
+    expect { described_class.file_without_address(path: "#{Dir.pwd}/spec/test_files/good/file_with_address/*.js") }
+      .not_to raise_error
   end
 end
diff --git a/spec/onlyoffice_rake_code_linter/onlyoffice_rake_code_linter_file_without_lf_ending_spec.rb b/spec/onlyoffice_rake_code_linter/onlyoffice_rake_code_linter_file_without_lf_ending_spec.rb
@@ -7,6 +7,7 @@
   end
 
   it 'do not raise error on file with lf ending' do
-    described_class.file_without_lf_ending("#{Dir.pwd}/spec/test_files/good/file_with_lf/*.js")
+    expect { described_class.file_without_lf_ending("#{Dir.pwd}/spec/test_files/good/file_with_lf/*.js") }
+      .not_to raise_error
   end
 end
diff --git a/spec/onlyoffice_rake_code_linter/onlyoffice_rake_code_linter_file_without_license_spec.rb b/spec/onlyoffice_rake_code_linter/onlyoffice_rake_code_linter_file_without_license_spec.rb
@@ -7,6 +7,7 @@
   end
 
   it 'do not raise error on file with license' do
-    described_class.file_without_license(path: "#{Dir.pwd}/spec/test_files/good/file_without_license/*.js")
+    expect { described_class.file_without_license(path: "#{Dir.pwd}/spec/test_files/good/file_without_license/*.js") }
+      .not_to raise_error
   end
 end
diff --git a/...office_rake_code_linter/onlyoffice_rake_code_linter_file_without_trailing_newline_spec.rb b/...office_rake_code_linter/onlyoffice_rake_code_linter_file_without_trailing_newline_spec.rb
@@ -7,6 +7,7 @@
   end
 
   it 'do not raise error on file with newline' do
-    described_class.file_without_trailing_newline("#{Dir.pwd}/spec/test_files/good/file_with_newline/*.js")
+    expect { described_class.file_without_trailing_newline("#{Dir.pwd}/spec/test_files/good/file_with_newline/*.js") }
+      .not_to raise_error
   end
 end